serhiy-bzhezytskyy commented on PR #4758: URL: https://github.com/apache/solr/pull/4758#issuecomment-5551977250
The marker isn't new — `FieldType.ExternalizeStoredValuesAsObjects` is Hoss's, from SOLR-18033 back in January (`90ef6ff725d`), and `DocsStreamer` on main already checks it next to `KNOWN_TYPES`. `KNOWN_TYPES` itself is `@Deprecated(since = "10.1")` and its javadoc says "new field types should not be added to this list, instead use ExternalizeStoredValuesAsObjects". So this PR removes the deprecated half of a mechanism that's already dual, rather than proposing a new one — my description didn't say the interface pre-existed, which is on me. I can still take it to dev@ if you want the wider read. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
