[
https://issues.apache.org/jira/browse/SOLR-18358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106611#comment-18106611
]
Serhiy Bzhezytskyy commented on SOLR-18358:
-------------------------------------------
Looked at the code before starting. "Incremental is already the default" is
true, but that only explains why most callers don't need the flag anymore — it
doesn't cover the one other thing this same flag gates.
commitName (CollectionAdminRequest.Backup.setCommitName, a public,
non-deprecated SolrJ method for backing up from a previously-created named
collection snapshot) is only handled inside BackupCmd.copyIndexFiles() -- the
incremental == false branch. There's no equivalent under incremental == true.
So setIncremental(false) isn't just an inefficient legacy storage format
anymore; for anyone using commitName, it's the only door to that feature.
Removing the setter and its code path as described would remove the ability to
back up from a named snapshot entirely, not just the deprecated full-snapshot
storage format. Is that intended, or should commitName-based backup be
preserved/ported to the incremental path first? [~epugh] WDYT?
> Remove CollectionAdminRequest.Backup.setIncremental(boolean)
> ------------------------------------------------------------
>
> Key: SOLR-18358
> URL: https://issues.apache.org/jira/browse/SOLR-18358
> Project: Solr
> Issue Type: Sub-task
> Reporter: Eric Pugh
> Priority: Minor
>
> `CollectionAdminRequest.Backup.setIncremental(boolean)` has been deprecated
> since 9.0. Incremental backups are already the default; the deprecated
> 'full-snapshot' format is being phased out. Remove the setter and the
> full-snapshot backup code path it controls.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
