[ 
https://issues.apache.org/jira/browse/SOLR-18358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106619#comment-18106619
 ] 

Eric Pugh commented on SOLR-18358:
----------------------------------

so, I believe that remove that feature has been the actual plan!   It's been on 
my list to try and figure out the situations, so thank you.

 

The ref guide: 
[https://solr.apache.org/guide/solr/latest/deployment-guide/collection-management.html#backup]
 says:

>> Previous versions of Solr supported a different backup file format that 
>> lacked the incremental support described above. Solr can still restore from 
>> backups that use this old format, but creating new backups of this format is 
>> not recommended and is officially deprecated. See the {{incremental}} 
>> parameter below for more information.

 

When I look up the incremental property it says:

 

>> A boolean parameter allowing users to choose whether to create an 
>> incremental ({{{}incremental=true{}}}) or a "full" 
>> ({{{}incremental=false{}}}) backup. If unspecified, backups are done 
>> incrementally by default. Incremental backups are preferred in all known 
>> circumstances and "full" (i.e. non-incremental) backups are deprecated, so 
>> this parameter should only be used after much consideration

 

So, I think that we need two things: 1) A PR that removes the code that folks 
can look at, and 2) A email to the dev@ mailing list flagging this.   We should 
get this resolved so that future users aren't confused about the right path...

 

I just worked on a project that ingested backups from many different versions 
of Solr, and oh boy it was not fun figuring out all the permutations in options 
+ standalone versus solrcloud.   

 

Since this would be a biggest feature change for some, maybe we want to move 
this to a Solr 11 only change to give time to folks who are on the 10x branch?  
 If we want this on 10x, the I think we HAVE to land it on 10.1 since that is 
the first version most users will actually adopt ;)

 

 

> Remove CollectionAdminRequest.Backup.setIncremental(boolean)
> ------------------------------------------------------------
>
>                 Key: SOLR-18358
>                 URL: https://issues.apache.org/jira/browse/SOLR-18358
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Eric Pugh
>            Priority: Minor
>
>  `CollectionAdminRequest.Backup.setIncremental(boolean)` has been deprecated 
> since 9.0. Incremental backups are already the default; the deprecated 
> 'full-snapshot' format is being phased out. Remove the setter and the 
> full-snapshot backup code path it controls.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to