serhiy-bzhezytskyy opened a new pull request, #4790:
URL: https://github.com/apache/solr/pull/4790
## What
Removes the deprecated
`SolrTestCaseJ4.systemSetPropertyEnableUrlAllowList(boolean)` and
`systemClearPropertySolrEnableUrlAllowList()` methods. Both were deprecated
since 9.0 (SOLR-17864) as backwards-compatibility shims only, with no
replacement API — `systemClearPropertySolrEnableUrlAllowList()` was already an
empty no-op.
## Scope
Bigger than a single method: 15 call sites across 13 files (`solr-core`
tests + 2 `solr-test-framework` base classes: `BaseDistributedSearchTestCase`,
`SolrTestCaseHS`).
- Migrated every `systemSetPropertyEnableUrlAllowList(value)` call to
`System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST,
String.valueOf(value))` directly — the exact body of the removed setter.
- Deleted every `systemClearPropertySolrEnableUrlAllowList()` call outright
(it did nothing).
- In `BaseDistributedSearchTestCase`, that left
`clearSolrEnableUrlUrlAllowList()` as an empty `@AfterClass` method with no
other callers, so the whole method (and its now-unused `@AfterClass` import)
was removed rather than left as a hollow shell.
- Dropped 8 `@SuppressWarnings("deprecation")` annotations across 4 test
files that existed solely to cover these calls.
## Verification
- Full-repo `./gradlew compileTestJava` (exit 0) — confirms zero remaining
references anywhere in the tree.
- Targeted test runs green across every touched test class
(`TestTolerantSearch`, `TestHealthCheckHandlerLegacyMode`,
`DistributedDebugComponentTest`, `TestSmileRequest`, `TestJsonRequest`,
`TestJsonFacetRefinement`, `TestJsonFacetErrors`, `TestJsonRangeFacets`,
`TestJsonFacets`, `TestReplicationHandler`,
`TestUserManagedReplicationWithAuth`).
## Changelog
`solr-test-framework` is a published Maven artifact and these were
`protected static` methods reachable by subclasses, so a `type: removed`
changelog entry is included.
AI-assisted (Claude Sonnet 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
