serhiy-bzhezytskyy commented on PR #4790: URL: https://github.com/apache/solr/pull/4790#issuecomment-5391858370
Checked -- #4215 (SOLR-18123) uses `CoreContainer.ALLOW_PATHS_SYSPROP` (filesystem path restrictions), a different mechanism from this PR's `systemSetPropertyEnableUrlAllowList`/`systemClearPropertySolrEnableUrlAllowList` (URL-allowlist). No file or symbol overlap. If anything, this PR does what you asked for on #4215 for a different property -- removes the base-class toggle-helper wrappers and inlines the one `System.setProperty(...)` call at its only remaining caller, instead of keeping ceremony in `SolrTestCaseJ4`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
