epugh commented on PR #4808: URL: https://github.com/apache/solr/pull/4808#issuecomment-5509015544
@serhiy-bzhezytskyy I opened up a thread on the dev mailing list about this: https://lists.apache.org/thread/rcvq7t7rm63wz096bj63qwcst8n8670l, and I'm hoping folks agree that this is just an 11 deprecation for now. Would you be interested in digging into, maybe as a follow up, what Jason suggested about: > The real problem as it pertains to non-incremental backups is that, despite being deprecated in 9.0, much of the underlying code is still used by the INSTALLSHARD feature that was added later in 9.x. We can probably clean up the cosmetics of "/admin/collections?action=BACKUP", remove the "incremental=true|false" flag, delete some of the tests, etc. But the bulk of the backing code can't be removed despite the API-level deprecation : ( It seems like what we have here is the API level deprecation, but maybe there is some other code that should more properly live elsewhere once the API level deprecation is done? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
