epugh commented on PR #4847: URL: https://github.com/apache/solr/pull/4847#issuecomment-5529565798
The new ErrorProne brought a set of new rules, some that are great, and one that maybe needs discussion. This commit is all reasonable seeming fixes/cleanups: 0743dd4ecd651638dbcc52a1b8e7aba4e2a754a2, however the suppression of `ReferenceEquality` was a LOT! See https://github.com/apache/solr/pull/4847/changes/3c713f109fde8b367f2ed4150ae66497cb9ebaed and I don't know what we think about this... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
