dsmiley commented on code in PR #4847:
URL: https://github.com/apache/solr/pull/4847#discussion_r3934972987
##########
gradle/validation/error-prone.gradle:
##########
@@ -456,7 +456,7 @@ allprojects {prj ->
'-Xep:NonCanonicalType:WARN',
'-Xep:NonOverridingEquals:WARN',
//'-Xep:NonFinalStaticField:WARN', // todo there are problems that
should be fixed
- '-Xep:NotJavadoc:WARN',
+ // '-Xep:NotJavadoc:OFF', // too many false positives on
stacked/non-public-API comments
Review Comment:
the rationale is inconsistent with the rationale I stated. I suggest simply
"we disagree; javadocs aren't purely for publishing"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
