adamjq commented on code in PR #4698:
URL: https://github.com/apache/solr/pull/4698#discussion_r3937372535


##########
solr/core/src/java/org/apache/solr/schema/ScalarQuantizedDenseVectorField.java:
##########
@@ -123,18 +124,28 @@ public void init(IndexSchema schema, Map<String, String> 
args) {
 
     super.init(schema, args);
 
-    if (FLAT_ALGORITHM.equals(getKnnAlgorithm())) {
+    if (VectorEncoding.BYTE.equals(getVectorEncoding())

Review Comment:
   Thanks, that's a good suggestion. I've made that update. This means that a 
field can be created with:
   ```
   ScalarQuantizedDenseVectorField 
       vectorEncoding=BYTE
       knnAlgorithm=flat
   ```
   The field will load but will only work with the `vectorSimilarity()` 
function query and not KNN query parsers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to