chan-dx commented on PR #4829:
URL: https://github.com/apache/solr/pull/4829#issuecomment-5589485726
@dsmiley **Heads-up:** I rebased before pushing, which resets review state.
I did that out of habit, sorry about that. Everything new is the last five
commits, from *Revert the ref-guide upgrade note* onward; that's all that needs
a fresh look. I'll merge `main` in rather than rebase from here.
_Since the PR is getting a bit long, here's the summary:_
All four points are addressed, with per-point replies on the threads above,
which GitHub now marks Outdated (the two on `SolrClient.java` no longer appear
under Files changed at all, since the predicates moved out of that file).
**Four calls I'd like from you.** The default in each case is what's on the
branch, so no reply needed unless you disagree.
1. **`getClient(Endpoint)` narrowed to `HttpSolrClient`**: the only
public-API change here, and a binary-compat break for out-of-tree subclasses.
*Default: keep.*
2. **If 1 stands, do you want a `major-changes-in-solr-10.adoc` line for
it?** *Default: skip.*
3. **The `doRequest` dead-branch commit**: its own commit, easy to drop if
you'd rather keep this narrower. *Default: keep the commit.*
4. **One behaviour change inside the catch-block collapse**
(`testQueryIsRetriedWhenUnsentButRootCauseIsNotIO`): a fix rather than a
refactor, so separable. *Default: keep.*
The `wasRequestUnsent` / `wasCommError` question is answered on its thread
above. **Short version:** `CloudSolrClient` needs both at the same catch: one
decides whether to invalidate cached cluster state, the other whether replaying
a non-idempotent update is safe.
Thanks again for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
