janhoy commented on PR #4177: URL: https://github.com/apache/solr/pull/4177#issuecomment-5730581101
> are you familiar iwth the versions=true property on indexing a documetn No > I think I am realizing that this is the PR that you are thinking we should "abandon it, i.e. let it die with V1 removal"? I'm not saying we should abandon this PR. But in order to get to strict JSON we need to abandon the "command" variant of an update request, which is the one that had the versions flag, right? This is probably a decision that should be floated on dev list. > It seems impossible to describe a update request body? But maybe that is me thinking old school? The way we mash everything into one `/update` endpoint now with the same content-type `application/json`, then yes it is impossible to do a concise OpenAPI spec for what we expect. But if we distinguish body format based on Content-Type I'm sure OpenAPI spec has a way to document body format per content-type. Including CSV etc. When #4910 lands, jsonlines updates will have its own content-type. If we kill json command format, then that will be gone, and what's left is pure JSON docs or array of json docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
