epugh commented on PR #4177:
URL: https://github.com/apache/solr/pull/4177#issuecomment-5741956552
Okay, I'm rethinking a bit... I think this PR should just finish getting us
to JAX-RS. Then we iterator in a seperate PR about removing command
behavior... So I am going to back out the /update/bin --> /update/javabin
change.
I am going to tackle these gaps:
## Gaps
1. High: The API contract declares no request bodies. WE DO NOT RETURN
STRONG TYPED RESPONSES FOR UPDATES. Wait.. maybe that can be fixed?
2. High: The API contract declares none of the supported query parameters
Parameters such as commit, commitWithin, overwrite, softCommit, and
versions work at runtime because the legacy handler reads them. This can be
fixed.
3. Medium: The /update OpenAPI summary disagrees with its behavior
Its summary says “using any supported content type” at
solr/api/src/java/org/apache/solr/client/api/endpoint/
UpdateApi.java:34, but the implementation always rewrites that endpoint
to /update/json/docs at solr/core/src/java/org/
apache/solr/handler/admin/api/UpdateAPI.java:62. The new Ref Guide
correctly describes /update as JSON only. The summary
should say “Index documents in JSON format.”
Going to fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
