epugh commented on PR #4924: URL: https://github.com/apache/solr/pull/4924#issuecomment-5774225499
> > For what it's worth, Picocli uses `picocli.CommandLine.Command` to annotate "this is a command"..... But again, we can use Tool... > > These can be both tools and commands. The individual classes are tools, and they can be invoked either from the CLI in which case it makes sense to document it user-facing as a bin/solr command. But PostTool can also be run standalone or embedded in some other bootstrap I suppose (at least it could earlier). I think we should keep the Tool naming in the code but refer to them as commands in the context of bin/solr. I can get behind that. So then in places where we emit something via bin/solr, like the `bin/solr post --help`, we have some text that says "Which mode the Post tool is running". Maybe we need to look at the wording and see if we can do something work to avoid saying "Tool" or "Command" in that message. So, for the example I gave, we could change the help text to be: ``` Specifies how to run: 'files' crawls local directories, 'web' crawls websites, 'args' processes positional arguments, and 'stdin' reads standard input stream. Default: files. ``` I like that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
