epugh commented on PR #4924: URL: https://github.com/apache/solr/pull/4924#issuecomment-5773840796
Great work @serhiy-bzhezytskyy ...... So looking at this more, and looking at the PostTool.java, and the fact that the name of the file is "PostTool" and then, looking at how we refer to things in https://github.com/apache/solr/pull/3254, for example "This tool does not yet support PicoCli", that then makes me feel like we need to either pick "Tool" or "Command" and then lean into the specific name, across BOTH the java code and the ref guide docs. That I think helps us the most, because we know how to grep for the code in both ref guide and source, etc. For what it's worth, Picocli uses `picocli.CommandLine.Command` to annotate "this is a command"..... But again, we can use Tool... @janhoy WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
