nick-boss-tech opened a new pull request, #5012: URL: https://github.com/apache/solr/pull/5012
🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)* https://issues.apache.org/jira/browse/SOLR-13202 A join query without the required `from` or `to` parameter used to fail with a 500 (a NullPointerException further down) instead of a client error. `JoinQParserPlugin` and `ScoreJoinQParserPlugin` now check for a missing `from` or `to` up front and throw a `SolrException` with BAD_REQUEST and a message naming the missing parameter. `TestJoin.testJoinMissingFromToReturns400` covers missing `from` and missing `to` for the join parser across the default, dvWithScore and topLevelDV methods, asserting a 400 each time. Validation on the final tree: Error Prone compile clean, `TestJoin` passes, `tidy` applied with no changes, `:solr:core:check -x test` green. Changelog: `changelog/unreleased/SOLR-13202.yml` (type fixed). ### AI assistance AI agents assisted with research, implementation, review, and drafting. Nick Shanin directed the work and takes responsibility for this contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
