nick-boss-tech commented on PR #5012: URL: https://github.com/apache/solr/pull/5012#issuecomment-6018272231
🤖 *AI text below* 🤖 *(posted on behalf of Nick Shanin)* Thanks, both are covered now, pushed in c0aec3a7ae0. For `AuxIndexJoinQParserPlugin`: it did reject a missing `from` or `to`, but with one combined SyntaxError naming both params at once. It now calls the same `ScoreJoinQParserPlugin.requireFromAndTo` helper as the other join parsers, so the 400 names the specific missing parameter. `TestAuxIndexJoinQParserPlugin.testMissingLocalParams` now covers missing `from` and missing `to` separately. For `GlobalOrdinalsJoinQParserPlugin`: that parser has no `from`/`to` params; its required inputs are `joinField`, `which`, and the from query, and those were already validated with 400s naming the input. The one case `testValidationErrors` did not cover was the missing from query, so I added that case. If you would rather see those checks converted to the same helper style anyway, I can do that as well. Gate: tidy, Error Prone compile, and `:solr:core:check -x test` pass; TestAuxIndexJoinQParserPlugin 4/4, TestGlobalOrdinalsJoinQParser 6/6, TestJoin 5/5, CrossCollectionJoinQueryTest 10/10. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
