[
https://issues.apache.org/jira/browse/SOLR-18119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18123642#comment-18123642
]
Jan Høydahl commented on SOLR-18119:
------------------------------------
[~hossman] I believe we may have two options here
# Fail loudly if python not found (Nick's PR #4999)
# Fall back to GraalPy and thus be able to run both checkBrokenLinks and
changes2html on any machine with a JDK (I'm testing this now)
I like option 2, the build will download GraalPy only on demand.
Preliminary local test shows that the GraalPy download is 153Mb, 17 jars,
changes2html.py runs in 3.9s instead of 0.5s with native py. The
checkJavaDocLinks check takes 55s compared to 14s with native python3.
> Changes.html generation is quietly skipped if python3 not found, can cause
> downstream tasks to fail confusingly
> ----------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-18119
> URL: https://issues.apache.org/jira/browse/SOLR-18119
> Project: Solr
> Issue Type: Bug
> Reporter: Chris M. Hostetter
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> ChangesToHtmlTask will log a warning if python3 doesn't exist – but it does
> not fail.
> downstream tasks that (implicitly) depend on the existence of Changes.html
> will subsequently fail...
>
> {noformat}
> :solr:documentation:checkBrokenLinks
> :solr:solr-ref-guide:checkSiteLinks{noformat}
>
> This can be very confusing on jenkins boxes – such as our Windows jenkins
> build, which does not have python3 – when people don't know/realize that
> {{:solr:documentation:changesToHtml}} quietly did nothing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
