janhoy opened a new pull request, #5054: URL: https://github.com/apache/solr/pull/5054
- **`SOLR_CONNECTION` fallback was dead on both parser paths.** `CliDefaultValueProvider` and `CLIUtils.resolveSolrConnectionFromCli` read the `solr-connection` property, but `EnvUtils` maps `SOLR_CONNECTION` to `solr.connection` and its camelCase fallback can't bridge a hyphen, so the documented "unnecessary if SOLR_CONNECTION is defined in solr.in.sh" never worked. Now reads `solr.connection`. Covered by the new `CliDefaultValueProviderTest` (picocli) and two tests in `CLIUtilsTest` (commons-cli). - **`bin/solr start --help` (picocli) still advertised `--prompt-inputs`**, which was renamed to `--script-inputs` in SOLR-18468; `bin/solr` and `RunExampleTool` already use the new name. - **`bin/solr create --help` example used `-s 2` for shards**; `-s` is `--solr-connection`, shards is `-sh`. Ref-guide CLI pages regenerated (`solr-start.adoc`, `solr-create.adoc`). No behaviour change on the commons-cli path other than the `SOLR_CONNECTION` fallback now taking effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
