janhoy commented on code in PR #5042:
URL: https://github.com/apache/solr/pull/5042#discussion_r4205514360


##########
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##########
@@ -82,6 +83,23 @@
 import org.xml.sax.SAXException;
 
 /** Supports post command in the bin/solr script. */
+@SuppressWarnings("UnnecessarilyFullyQualified")
[email protected](
+    name = "post",
+    description =
+        "The Post command sends one or more files, directories, URLs or 
literal data to a"
+            + " collection for indexing.",
+    footerHeading = "%nExamples:%n",
+    footer = {
+      "  # Index all JSON files into a collection",
+      "  bin/solr post -c gettingstarted *.json",
+      "",
+      "  # Index a tab-separated file, using the CSV handler's separator 
param",
+      "  bin/solr post -c gettingstarted --params \"separator=%%09\" --type 
text/csv data.tsv",

Review Comment:
   Please verify the generated `solr-post.adoc` shows `%09`, not `%%09`.



##########
solr/packaging/test/test_postlogs.bats:
##########
@@ -42,7 +42,7 @@ teardown() {
   run solr create -c COLL_NAME
   assert_output --partial "Created collection 'COLL_NAME'"
 
-  run solr postlogs --solr-url http://localhost:${SOLR_PORT} -c COLL_NAME 
-rootdir ${SOLR_LOGS_DIR}/solr.log
+  run solr postlogs --solr-url http://localhost:${SOLR_PORT} -c COLL_NAME 
--rootdir ${SOLR_LOGS_DIR}/solr.log

Review Comment:
   Please check the ref guide only spells it `--rootdir`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to