janhoy commented on code in PR #5041:
URL: https://github.com/apache/solr/pull/5041#discussion_r4205513987
##########
solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java:
##########
@@ -213,7 +249,65 @@ protected void runCloudTool(CloudSolrClient
cloudSolrClient, HealthcheckParams p
@Override
public int callTool() throws Exception {
- throw new UnsupportedOperationException("This tool does not yet support
PicoCli");
+ var solrConnection = resolveSolrConnection(credentialsOptions.credentials);
Review Comment:
Optional: on the picocli path `return 1` after the `CLIO.err(...)` is
simpler than `runtime.exit(1)` followed by code that must never run.
##########
changelog/unreleased/SOLR-18514-picocli-healthcheck.yml:
##########
@@ -0,0 +1,9 @@
+# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
+
+title: The `healthcheck` command is now available in the experimental picocli
command line interface.
Review Comment:
No picocli feature has been released yet, so if this lands in 10.2 toghether
with the feature, it may read a bit weird with 12 different CHANGELOG lines
which really are just details for the same new feature.
May I suggest that we instead (for all PRs) update the same entry that is
already on main, adding `authors` and `links` to add each jira number to the
same yml file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
