jaykay12 commented on code in PR #5052:
URL: https://github.com/apache/solr/pull/5052#discussion_r4213763944
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##########
@@ -278,18 +279,20 @@ public Map<String, SolrPackageInstance>
getPackagesDeployedAsClusterLevelPlugins
Map<String, String> packageVersions = new HashMap<>();
// map of package name to multiple values of pluginMeta(Map<String,
String>)
Map<String, Set<PluginMeta>> packagePlugins = new HashMap<>();
- Object pluginsValue;
+ Object pluginsValue = null;
try {
NamedList<Object> response =
solrClient.request(
new GenericV2SolrRequest(SolrRequest.METHOD.GET,
PackageUtils.CLUSTERPROPS_PATH));
Integer statusCode = (Integer) response._get(List.of("responseHeader",
"status"), null);
- if (statusCode == null || statusCode == ErrorCode.NOT_FOUND.code) {
- // Cluster props doesn't exist, that means there are no cluster level
plugins installed.
- pluginsValue = null;
- } else {
+ if (statusCode != null && statusCode != ErrorCode.NOT_FOUND.code) {
+ // Cluster props exists, that means there are cluster level plugins
installed.
pluginsValue = response.get(ContainerPluginsApi.PLUGIN);
}
+ } catch (RemoteSolrException ex) {
+ if (log.isDebugEnabled()) {
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
