epugh commented on code in PR #5022:
URL: https://github.com/apache/solr/pull/5022#discussion_r4237317592
##########
solr/solrj/src/resources/java-template/api.mustache:
##########
@@ -233,14 +233,14 @@ public class {{classname}} {
@Override
public SolrParams getParams() {
- final ModifiableSolrParams params = new ModifiableSolrParams();
+ final ModifiableSolrParams solrParams = new
ModifiableSolrParams();
Review Comment:
can you give some context on why this rename is needed? Is this a tidy, or
was the name clashing? for soem reason i get nervoius every time we touch the
mustache templating, maybe cause it seems like magic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
