nick-boss-tech commented on PR #5235: URL: https://github.com/apache/solr/pull/5235#issuecomment-6436041434
**One blocking finding at `16d9e2823daf`:** **[P1] Missing unchecked suppression in [`[ApiBag.readCommands](https://github.com/apache/solr/blob/16d9e2823dafe409cb8f5015800466cbc1de5c7f/solr/core/src/java/org/apache/solr/api/ApiBag.java#L449)`](https://github.com/apache/solr/blob/16d9e2823dafe409cb8f5015800466cbc1de5c7f/solr/core/src/java/org/apache/solr/api/ApiBag.java#L449).** Restoring the parser body reintroduced a raw `NamedList.add` call, but the method suppresses only deprecation warnings. The unchecked warning fails compilation under `-Werror`. **All four failing CI workflows confirm this.** The minimal fix is: ```java @SuppressWarnings({"deprecation", "unchecked"}) ``` Minor cleanup: the PR body still incorrectly lists the removed `isMultipart` overload as restored. [Full review](/C:/Users/shaninna/dev/Solr-issues/research/branch-reviews/2026-10-27-pr-batch/PR-5235-review.md). AI-generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
