janhoy commented on code in PR #827:
URL: https://github.com/apache/solr-operator/pull/827#discussion_r4389749115
##########
api/v1beta1/solrcloud_types.go:
##########
@@ -1327,6 +1328,49 @@ func (zkInfo ZookeeperConnectionInfo)
ZkConnectionString() string {
return zkInfo.InternalConnectionString + zkInfo.ChRoot
}
+// solrImageTagVersionRegex matches Solr image tags, which must start with the
Solr version, "<major>[.<minor>[.<patch>...]]".
+// Anything after the version must start with neither a digit nor a dot,
+// e.g. "10.0.0", "10.1.0-SNAPSHOT", "10.0.0.1", "10.0.0@sha256:...",
"9.10-slim" or "8.11".
+// Short versions are accepted because released Solr Operator versions
defaulted to tags such as "8.11",
+// and they cannot change their major version.
+var solrImageTagVersionRegex =
regexp.MustCompile(`^(?P<major>\d+)(?:\.\d+)*(?:[^\d.].*)?$`)
+
+const (
+ // The range of Solr major versions that the Solr Operator supports.
+ MinSupportedSolrMajorVersion = 8
Review Comment:
Such changes should ideally only be made in major version, i.e. v1.0.0.
I was hoping to be able to release a last v0.x release with solr 10 support,
but I'm also open to just jump straight to v1.0.0 and lift the floor to 9.0.0
if that makes us drop lots of baggage and simplify things. We can also discuss
this in the dev@ thread about release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
