nick-boss-tech commented on PR #5251: URL: https://github.com/apache/solr/pull/5251#issuecomment-6457683261
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* Hi @elangelo, I have a tested follow-up for the mixed-precision case you noted: [one-commit diff](https://github.com/nick-boss-tech/solr/compare/ca539cad196f26c78e14a1dc698b84e0f5c1f22e...e7834ca954505c27778e59a61140bf02490226a6). It rejects different register counts or widths before union, with an error naming `solr.facet.hll.log2m` and both layouts. Different explicit thresholds still merge. It also adds regression tests and documents the restart requirement. Verified on Linux at `e7834ca…`, using JDK 21.0.12.1, Gradle 9.7.0 and seed `5251C0DE`: - 11 focused tests, 12 local/distributed JSON facet cases, and 27 neighboring tests passed, with no skips. - Tidy, root `check -x test`, and reference-guide build/link checks passed, with `NODE_ENV` unset. - All five rejection regressions fail against the original production code: four allow the mismatch, and the smaller-source merge throws `ArrayIndexOutOfBoundsException`. The commit is a fast-forward of the current PR head: ```sh git switch json-facet-hll-precision git fetch https://github.com/nick-boss-tech/solr.git solr-18598-submit git merge --ff-only e7834ca954505c27778e59a61140bf02490226a6 ``` Would you like to include this guard in the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
