elangelo commented on PR #5251: URL: https://github.com/apache/solr/pull/5251#issuecomment-6462743085
Thanks, the guard makes sense: this PR is what makes a mismatched log2m possible. I've merged your commit as is and added a small follow-up (33c30b2608): - Changelog: kept the original title with a clause about the new failure, and both authors. - Ref guide: folded the restart note into the log2m bullet, so it is stated once; the expthresh bullet says shards may differ. - Tests: HLLUnionTest already checks log2m and regwidth mismatches for every representation, so HLLAggTest keeps one log2m test for the SolrException mapping, plus the two expthresh merge tests. I dropped the empty-shard test, since it covers existing behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
