sarkaramrit1993 opened a new pull request, #5259:
URL: https://github.com/apache/solr/pull/5259

   # Description
   
   [SOLR-18602](https://issues.apache.org/jira/browse/SOLR-18602): 
`DELETEREPLICA` with `count` ignores `followAliases`, so 
`collection=myAlias&count=1&followAliases=true` fails with `Could not find 
collection : myAlias`. `DeleteReplicaCmd.call` routes count requests to 
`deleteReplicaBasedOnCount` before it reads `followAliases`. Deleting by 
replica name already resolves the alias.
   
   # Solution
   
   Resolve the alias in `deleteReplicaBasedOnCount` the same way the 
replica-name path does.
   
   # Tests
   
   `DeleteReplicaTest.deleteReplicaByCountFollowsAliases` deletes by count 
through an alias, for one shard and across all shards. It fails on main and 
passes with the fix. `DeleteReplicaTest`, `TestCollectionAPI` and 
`AliasIntegrationTest` pass.
   
   Related to [SOLR-18589](https://issues.apache.org/jira/browse/SOLR-18589) 
(#5255).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to