sarkaramrit1993 commented on PR #5259:
URL: https://github.com/apache/solr/pull/5259#issuecomment-6960346374
Thanks @dsmiley for the review, and +1: the change is in the Cmd, not the
API surface.
Thanks @epugh too. The fix is in `DeleteReplicaCmd`, which both APIs reach.
v1 `DELETEREPLICA` goes through `DeleteReplica.invokeWithV1Params`, the v2
class, and the v2 `DELETE .../shards/{shard}/replicas?count=` endpoint builds
the same `DELETEREPLICA` message with `followAliases`. So the test's v1 call
already runs the v2 code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]