danielmeint commented on PR #827: URL: https://github.com/apache/solr-operator/pull/827#issuecomment-6502972796
> It would be beneficial if the Operator could log a fat ERROR if attempting to start a SolrPrometheusExporter based on a Solr10.x image. Log and abort, instead of failing with some command not found error msg (or whatever it does now?) > we can add an event to the SolrPrometheusExporter resource that says it's not supported done, the operator now doesn't reconcile a `SolrPrometheusExporter` if a Solr 10 image is used, but it emits an `UnsupportedSolrVersion` warning event and also logs an error > a wild idea could be to let the Operator discover the version by kicking a k8s Job that does nothing more than print the version Wild idea indeed :) personally, I'd be skeptical the additional complexity makes anyone's life easier 😅 extra pod, pull secret, permission, ... A slightly "lighter" alternative could be to read the `org.opencontainers.image.version` OCI label which the official images carry ([reference](https://github.com/apache/solr-docker/blob/884b2e6692174ea09cdb5183b8dd585760b5e9fb/10.0/Dockerfile#L86)) and images built `FROM solr` inherit. This could be read via [go-containerregistry](https://github.com/google/go-containerregistry) and cached by digest 🤔 It would still require registry access and probably has other caveats, so I'm not convinced either and I'd stick with tag parsing for this PR at least -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
