nick-boss-tech commented on PR #5264: URL: https://github.com/apache/solr/pull/5264#issuecomment-6503323789
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* I added a focused regression test for the web identity credentials path, if you would like to include it. It starts a child JVM with the Security Manager and your shipped policy, plus read access to the child's classpath, and resolves dummy credentials against a local STS stub. It needs neither Docker nor an AWS account and leaves the existing Testcontainers suite unchanged. On Linux with Temurin 21.0.12.1 and seed `18610C0DE`, the test executes and passes with your existing TCP grants: 1 test, 0 failures, errors or skips. With only the policy replaced by the pre-PR version, the same test fails at Apache5HttpClient's permission check, with `AccessControlException` for `setOption.TCP_KEEPIDLE`. The added classpath permissions grant file reads only, so they do not mask the network permission regression. Java 24+ skips this test because the Security Manager is unavailable. `tidy` and root `check -x test` also pass at `f93d00367d8a9861fd8edbfb51b6ab83ae59c156`. The initial check failed in Antora because `NODE_ENV=production` omitted its tabs devDependency; the successful check ran in a plain clone with `NODE_ENV` unset. The [addition to your current head](https://github.com/nick-boss-tech/solr/compare/dbb3d85d72dd27889d8b93f10d1f4c2f54aa5e0e...f93d00367d8a9861fd8edbfb51b6ab83ae59c156) is one test file; your production policy and changelog are unchanged. To take the tested commits without rewriting history: ```sh git switch s3-web-identity-security-manager git fetch https://github.com/nick-boss-tech/solr.git solr-18610-submit git merge --ff-only f93d00367d8a9861fd8edbfb51b6ab83ae59c156 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
