epugh commented on PR #5264: URL: https://github.com/apache/solr/pull/5264#issuecomment-6661642449
thanks @nick-boss-tech for the verification of the fix... I looked at https://github.com/apache/solr/compare/main...nick-boss-tech:solr:solr-18610-submit and it helped me build confidence in this change. I continue to worry about the balance of "additional tests versus teh value of the bug" and in something like this where the fix is pretty simple: unblock the permissions, I think we don't need the test comitted. But seeing your work helped me understand the fix, so please do continue! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
