epugh commented on code in PR #5107:
URL: https://github.com/apache/solr/pull/5107#discussion_r4444196538
##########
solr/core/src/java/org/apache/solr/cli/ConfigSetDownloadTool.java:
##########
@@ -64,6 +63,8 @@ public class ConfigSetDownloadTool extends ToolBase {
@picocli.CommandLine.Mixin ZkConnectionOptions zkOpts;
+ @Mixin private ZkCredentialsOptions zkAuth;
Review Comment:
why are we `@Mixin` versus `@picocli.CmmandLine.Mixin`? I mean, I get it,
but actually, maybe surprise that error prone didn't puke on
`@picocli.CommandLine.Mixin`!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
