epugh commented on PR #5107: URL: https://github.com/apache/solr/pull/5107#issuecomment-6585608919
> The branch merges your head `7d193dac0f` with the security-review fixes (both histories preserved, no rebase) and adds three commits on top: the repair itself, the generated start-page synchronization, and the removal of the two scoped changelog fragments. RunExampleTool already accepts `--credentials`; `bin/solr` rejected the option as unsupported, so the repair teaches the shell script to forward `--credentials` and `-u` to example starts as separate arguments, interesting... So, I actually don't have a good sense of if our examples actually work well if you run jthem twice... generally in development I'l do a `gradlew clean dev` just to reset thigns. I think, for simpliciity just at this point, I'll make it so it explicit that if you do run an example twice, it just steps on things. so `bin/solr start -e secure-setup` would just step over any previous `bin/solr start -e secure-setup`. We really probably should verify that if you run ``` bin/solr start -e techproducts #and then bin/solr start -e films ``` that process still works... I actually wou'ndt be surprise if you got werid shit, I've never tested that flow.. interested in poking at that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
