kotman12 opened a new pull request, #5300: URL: https://github.com/apache/solr/pull/5300
https://issues.apache.org/jira/browse/SOLR-18615 # Description Browser caches admin resources across major versions and this could cause problems during upgrades. The latest were random banners that appeared because angular didn't evaluate {code}ng-show{code} flags after something broke upstream of it. This, in turn, was caused by new UI code mixing with stale, cached UI code. # Solution Add a no-cache header so the browser periodically refreshes the assets. I've also updated the explicit cache buster as this is still valuable in certain circumstances, i.e. if a proxy overrides said header. # Tests Validate that no-cache header is set and that we always pass some query string. The version buster validation is not strict as it is difficult to achieve nicely with bash's ERE regex which doesn't have lookahead. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
