kotman12 commented on code in PR #5300:
URL: https://github.com/apache/solr/pull/5300#discussion_r4483617626
##########
solr/packaging/test/test_adminconsole_urls.bats:
##########
@@ -51,6 +51,16 @@ teardown() {
assert_output --partial "{"
}
+@test "assert admin console static assets are revalidated and versioned" {
+ run solr start
+
+ run curl -s -I http://localhost:${SOLR_PORT}/solr/libs/solr/index.js
+ assert_output --partial "Cache-Control: no-cache"
+
+ run curl -s http://localhost:${SOLR_PORT}/solr/
+ refute_output --regexp '(src|href)="[^"]+\.(js|css)"'
Review Comment:
Selenium tests build their own jetty and don't read the web.xml we actually
ship in the distro (which is the actual source of the bug). I suppose we could
have it parse the web.xml instead of handcrafting it in the tests but that is a
bigger undertaking as some of the tests touch jetty internals directly (i.e.
`configureCluster`). I am not sure if that is a direction worth taking? I don't
have any experience with the selenium test so am looking for guidance.
Theoretically it should be possible but not sure what roadblocks we could hit
trying to parse the distro web.xml in the selenium tests rather than having it
be a separate test resource. There is also the question of adding
jetty-ee10-webapp as a dependency to the test framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
