kotman12 commented on code in PR #5300: URL: https://github.com/apache/solr/pull/5300#discussion_r4486338279
########## solr/webapp/web/index.html: ########## Review Comment: We don't _need_ it but it will be helpful for 10.1->10.2 at least since index.html is cache busted so it will bootstrap the new cache-busted index.js reference right away. Cache control settings are per resource so you can still hit the same bug when upgrading to 10.2 without it. Also, in the off-chance you run through a proxy which alters headers it is a failsafe. That being said I can remove it as @epugh also seemed eager to get rid of it per https://github.com/apache/solr/pull/5300#discussion_r4483413415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
