dsmiley commented on PR #5289: URL: https://github.com/apache/solr/pull/5289#issuecomment-6717497175
🤖 This PR broke the `Solr-Smoketest-main` CI job ([build 19](https://ci-builds.apache.org/job/Solr/job/Solr-Smoketest-main/19/)). `dev-tools/scripts/smokeTestRelease.py` still requires `example` in the slim tgz root, so the job now fails with: ``` unpack solr-11.0.0-slim.tgz... ... Checking example RuntimeError: file "example" is missing ``` The failing check is the `isSlim` branch of `verifyBinaryUnpacked`: ```python is_in_list(in_root_folder, ['bin', 'docker', 'example', 'licenses', 'server', 'lib']) ``` Suggested fix: drop `'example'` from the slim list only. The full tgz list must keep it, because `is_in_list` also removes entries from `in_root_folder`, and anything left over is reported as an unexpected file or dir. With the fix, a slim tgz that ships `example` again fails as unexpected, which seems right. The full distribution is also exercised by `testSolrExample`, which indexes `example/exampledocs`. I haven't confirmed whether anything else in the smoketester assumes examples exist in slim. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
