epugh commented on code in PR #5310:
URL: https://github.com/apache/solr/pull/5310#discussion_r4512525849
##########
solr/docker/tests/shared.sh:
##########
@@ -16,6 +16,12 @@
# Shared functions for testing
+function post_test_document {
Review Comment:
i think we are getting close... So this may be an "eric" thing, but as
I am reading the various tests, I like seeing the `docker exec` inline. It
makes it really easy for me to understand everything going on casue I can see
the individual commands... (It's part of why I like bats tests often over the
complex Junit ones for cloud, it just mimics closer how *I* interact with
Solr)... How strongly do we feel about having this helper?
`post_test_document` is literally a one line function once you remove the
`local` variable declaration! I'm okay with seeing the json doc repeated over
and over in the tests scripts. If the length of it is casuing wrapping, I'd
even be onboard with maybe simplifying the doc to not cause wrapping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
