epugh commented on code in PR #5310:
URL: https://github.com/apache/solr/pull/5310#discussion_r4502323348
##########
solr/docker/tests/shared.sh:
##########
@@ -16,6 +16,25 @@
# Shared functions for testing
+function post_test_document {
+ local core=$1
+ docker exec --user=solr "$container_name" bin/solr post -c "$core" --mode
args --type application/xml \
Review Comment:
any pro/con in swapping to json here? Just to be a bit newer in flavour?
##########
.github/workflows/docker-test.yml:
##########
@@ -16,12 +16,18 @@ concurrency:
jobs:
test:
- name: Build and test Docker image
+ name: Build and test Docker image (${{ matrix.dist }})
+
+ strategy:
+ fail-fast: false
+ matrix:
+ dist: [full, slim]
runs-on: ubuntu-latest
timeout-minutes: 15
env:
+ SOLR_DOCKER_DIST: ${{ matrix.dist }}
Review Comment:
Not totally sure how we ar eusing this?
##########
solr/docker/tests/shared.sh:
##########
@@ -16,6 +16,25 @@
# Shared functions for testing
+function post_test_document {
+ local core=$1
+ docker exec --user=solr "$container_name" bin/solr post -c "$core" --mode
args --type application/xml \
+ '<add><doc><field name="id">dell</field><field name="address_s">One Dell
Way Round Rock, Texas 78682</field></doc></add>'
+}
+
+function assert_demo_unavailable {
+ local status
+ status=$(docker wait "$container_name")
Review Comment:
I see later on the `SOLR_DOCKER_TEST_SLIM` which might simplify this?
##########
solr/docker/tests/shared.sh:
##########
@@ -16,6 +16,25 @@
# Shared functions for testing
+function post_test_document {
+ local core=$1
+ docker exec --user=solr "$container_name" bin/solr post -c "$core" --mode
args --type application/xml \
+ '<add><doc><field name="id">dell</field><field name="address_s">One Dell
Way Round Rock, Texas 78682</field></doc></add>'
+}
+
+function assert_demo_unavailable {
+ local status
+ status=$(docker wait "$container_name")
Review Comment:
is there any way to simplify? I like the check inside `solr-demo`, but then
this piece of logic looks complex... potnetially error prone? I wonder if we
can just check "am I in slim or full" via a constant or variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
