kotman12 commented on PR #5301: URL: https://github.com/apache/solr/pull/5301#issuecomment-6751927034
> @nick-boss-tech I added your changes to `testConnectionManagerFollowsZooKeeperAcrossDisconnectsAndExpirations` without the `ConnectionManager` changes you made and it still passes. I can't really wrap my head around why yours would be needed, and without an integration test that fails it's hard to convince myself. For now I'm going to move forward without your `ConnectionManager` change. (I will add your changes to the stress test though). FWIW I am able to recreate this with `./gradlew :solr:core:test --tests "org.apache.solr.common.cloud.ConnectionManagerOrderingTest.testExpiredReplacementDoesNotBlockRecovery"` against https://github.com/kotman12/solr/commit/b40cf008ccbdd10b8cf823ee93a8b59d76acfd13 (I pinned the seed that @nick-boss-tech cited) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
