kotman12 commented on PR #5301:
URL: https://github.com/apache/solr/pull/5301#issuecomment-6752468361

   Tldr;
   
   If you have some session A's expiry routine running and the session B it 
kicks off gets a `DISCONNECTED` before `CONNECTED` then this latest change 
disrregards the `CONNECTED` event. Previously the `CONNECTED` event would 
(incorrectly) flip the `connected` flag and _incidentally_ free the session A 
expiry thread waiting on:
   
   ```
    while (!connected && left > 0) {...}
    ```
    
    This thread would for a brief moment think it was connected but quickly 
error out. But at least it wasn't stuck. Now I don't know what I think yet of 
@nick-boss-tech proposed fix to poll the connected state but I do think this is 
an issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to