HoustonPutman commented on code in PR #894:
URL: https://github.com/apache/solr-operator/pull/894#discussion_r4517706453
##########
api/v1beta1/solrcloud_types.go:
##########
@@ -1153,6 +1181,12 @@ type SolrCloudStatus struct {
// ZookeeperConnectionInfo is the information on how to connect to the
used Zookeeper
ZookeeperConnectionInfo ZookeeperConnectionInfo
`json:"zookeeperConnectionInfo"`
+ // AppliedReplicaPlacementFactory is a hash of the
replicaPlacementFactory section that the operator
+ // last applied to the cluster, used to detect when it needs to be
re-applied. Empty when no
+ // placement plugin is managed by the operator.
+ // +optional
+ AppliedReplicaPlacementFactory string
`json:"appliedReplicaPlacementFactory,omitempty"`
Review Comment:
Should we instead keep this in the statefulSet annotations, like we do for
the other hashes? (I do know they mostly live in the pod annotations, where
this would live in the statefulset annotations because we don't want a
restart).\
Maybe instead we have a section for `Status.appliedSettings` and have
`replicaPlacementFactory` as a key in there? Because I imagine that we could
have other settings added in the future. Though in the future, hopefully Solr
has a Kubernetes plugin that will allow this stuff to just live in Kubernetes
configMaps instead of zookeeper...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
