HoustonPutman commented on code in PR #894:
URL: https://github.com/apache/solr-operator/pull/894#discussion_r4567300680


##########
api/v1beta1/solrcloud_types.go:
##########
@@ -1153,6 +1181,12 @@ type SolrCloudStatus struct {
        // ZookeeperConnectionInfo is the information on how to connect to the 
used Zookeeper
        ZookeeperConnectionInfo ZookeeperConnectionInfo 
`json:"zookeeperConnectionInfo"`
 
+       // AppliedReplicaPlacementFactory is a hash of the 
replicaPlacementFactory section that the operator
+       // last applied to the cluster, used to detect when it needs to be 
re-applied. Empty when no
+       // placement plugin is managed by the operator.
+       // +optional
+       AppliedReplicaPlacementFactory string 
`json:"appliedReplicaPlacementFactory,omitempty"`

Review Comment:
   > What's the difference? A SolCloud has exactly one Statefulset, so they are 
on the "same level"? But if other hashes live in Statefilset that's an 
argument. 👍
   
   The difference to me is when things are deleted. Someone could delete the 
SolrCloud status (why I don't know). What do we expect to happen there? Someone 
could delete the statefulSet, what do we expect to happen then? I think this 
makes sense to live in the status, because deleting the statefulSet will have 
no impact on the zNode that the replicaPlacementFactory lives in. So I'm glad 
you went with `Status.appliedSettings`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to