mlbiscoc commented on code in PR #5244: URL: https://github.com/apache/solr/pull/5244#discussion_r4543366499
########## solr/monitoring/otel-collector-config.yaml: ########## Review Comment: If these are example configs isn't the aspire part kind of weirdly specific? Maybe if this is specific for metrics/traces going to aspire, then it should be called an aspire config in the name. Otherwise someone who just wants to test an otel config for Solr and copies this will just see a bunch of errors to aspire. Or maybe comment it out and put a comment saying to "uncomment for aspire" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
