janhoy commented on code in PR #5244:
URL: https://github.com/apache/solr/pull/5244#discussion_r4616607062


##########
solr/monitoring/otel-collector-config.yaml:
##########


Review Comment:
   I see what you get at. The intention was not to do something for Aspire. 
It's just a dev tool to view raw telemetry in a nice UI.
   
   So perhaps if we rename `otlp/aspire --> otlp/raw` and `metrics/aspire --> 
metrics/raw`, and replace "Aspire" wording in header comments with some generic 
"Raw metrics firehose" (what in our demo setup is visualized in Aspire UI). 
Then it is perhaps less confusing for folks who wonder if they need this Aspire 
thing :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to