[
https://issues.apache.org/jira/browse/SOLR-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18144115#comment-18144115
]
Amrit Sarkar commented on SOLR-5939:
------------------------------------
Confirmed this still reproduces on {{main}}. When a stream to one node fails
with a retriable error, {{SolrCmdDistributor.doRetriesIfNeeded}} resubmits only
the {{Req}} that the {{ErrorReportingConcurrentUpdateSolrClient}} was built
with. The other requests in flight to that node are never retried, and
{{getErrors()}} comes back empty. Sending three adds to one node with one
retriable failure indexes one doc, and the caller sees success.
On the leader to replica path it's worse than a lost client update: the retry
"succeeds", so the replica isn't put into a lower term and never recovers.
[PR #5075|https://github.com/apache/solr/pull/5075] fixes it. The same
three-doc check indexes all three on that branch. I've left a review there.
> Wrong request potentially on Error from StreamingSolrServer
> -----------------------------------------------------------
>
> Key: SOLR-5939
> URL: https://issues.apache.org/jira/browse/SOLR-5939
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 6.0
> Reporter: Per Steffensen
> Priority: Major
> Labels: difficulty-medium, error, impact-low,
> pull-request-available, retry
> Fix For: 4.9, 6.0
>
> Attachments: SOLR-5939_demo_problem.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In _StreamingSolrServer.getSolrServer|ConcurrentUpdateSolrServer.handleError_
> the _SolrCmdDistributor.Req req_ parameter is used for the _req_ field of all
> _error_'s created. This is also true for subsequent requests sent through the
> retuned ConcurrentUpdateSolrServer. This means a.o. that wrong request (the
> first request sent through this _ConcurrentUpdateSolrServer_) may be retried
> if case of errors executing one of the subsequent requests.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]