janhoy commented on PR #5323:
URL: https://github.com/apache/solr/pull/5323#issuecomment-6850379813
Thanks for all the reviews. I'll chew through them. Re the name, in the
first iteration I felt this kind of tests needed its own identity. Now we say:
This should be a BATS test. I felt that "You should write a shell test" or
"Please write a SolrShelTest" was kind of generic, so CATS was both more
preceise identity for these tests as well as much more fun. It's not user
facing like SolrCell or SolrCloud, only developer facing so I feel it's
defendable 😉
Next steps planned
- Handle review feedback
- Factor out writing-tests.adoc into its own PR
- Split the code in test-framework into a core cats module and the solr
parts of it
Regarding the last bullet, I intend to move the core CATS framework into its
own module `test-framework-cats` which gets its own jar. Then the
`org.apache.solr.shell` part of `test-framework` becomes much thinner and gives
a better code structure for free. It will not change how tests are written so
this is mechanical. Things will move around, so will do this once first wave of
reviews have silenced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]