epugh commented on code in PR #5342:
URL: https://github.com/apache/solr/pull/5342#discussion_r4568624646
##########
solr/core/src/java/org/apache/solr/cli/ConfigSetDownloadTool.java:
##########
@@ -120,7 +120,9 @@ public void runImpl(CommandLine cli) throws Exception {
try (SolrZkClient zkClient = CLIUtils.getSolrZkClient(cli, zkHost)) {
doDownconfig(zkClient, zkHost, confName, confDir);
} catch (Exception e) {
- log.error("Could not complete downconfig operation for reason: ", e);
+ if (isVerbose() || !isZkConnectTimeout(e)) {
Review Comment:
do we want the isVerbose? shouldn't the tool burp out the error message
even if you aren't running in verbose mode?
##########
solr/packaging/test/test_zk.bats:
##########
@@ -66,6 +66,15 @@ teardown() {
assert_output --partial "aliases.json"
}
+@test "unreachable ZooKeeper reports a connection timeout" {
+ run solr zk ls / -z 127.0.0.1:1
+ assert_failure
+ assert_output --partial "ZooKeeper did not respond within the connection
timeout"
+ assert_output --partial "Solr node hosting it is running"
Review Comment:
i think I would be fine with half the asserts in this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]