nick-boss-tech commented on code in PR #5342:
URL: https://github.com/apache/solr/pull/5342#discussion_r4568948484
##########
solr/core/src/java/org/apache/solr/cli/ConfigSetDownloadTool.java:
##########
@@ -120,7 +120,9 @@ public void runImpl(CommandLine cli) throws Exception {
try (SolrZkClient zkClient = CLIUtils.getSolrZkClient(cli, zkHost)) {
doDownconfig(zkClient, zkHost, confName, confDir);
} catch (Exception e) {
- log.error("Could not complete downconfig operation for reason: ", e);
+ if (isVerbose() || !isZkConnectTimeout(e)) {
Review Comment:
Yes, the shared handler in `ToolBase` prints the error message without
verbose mode; this condition suppresses the duplicate tool-level stack trace
for this timeout unless verbose mode is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]