github-actions[bot] commented on PR #5346: URL: https://github.com/apache/solr/pull/5346#issuecomment-6882048201
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ⚠️ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference) **— differs from the entry** (suggest type: changed; PR has type: fixed): The change modifies the behavior of `bin/solr stop` to read the stop port from the running process rather than assuming a single `STOP_PORT` or derived value, which is an improvement to existing behavior that users will notice when managing multiple nodes with different stop ports. - ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide): included <!-- The PR adds a new `STOP_PORT` configuration option in `solr.in.sh`/`solr.in.cmd` and changes how the stop port is resolved, both of which are user-facing configuration and behavior changes that should be documented in the Reference Guide. --> - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): not needed <!-- The change is backwards-compatible; nodes started without an explicit `STOP_PORT` still use the derived port, and the new logic only improves the ability to stop nodes that were started with a custom `STOP_PORT`. --> - ⚠️ Tests **— probably not needed**: The PR includes a new Bats test (`test_start_solr.bats`) that specifically verifies the new behavior of stopping nodes on their own stop ports, covering the non-trivial production logic changes in the CLI and process manager. <!-- Assessed commit 44a5e47b8d1a3644005216eb27d1d2dec95a671c --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
